Skip to content

[C++] fix helpers import#364

Merged
mayank31398 merged 3 commits intomainfrom
n
Jan 30, 2026
Merged

[C++] fix helpers import#364
mayank31398 merged 3 commits intomainfrom
n

Conversation

@mayank31398
Copy link
Collaborator

No description provided.

Signed-off-by: Mayank Mishra <mayank31398@gmail.com>
Signed-off-by: Mayank Mishra <mayank31398@gmail.com>
Signed-off-by: Mayank Mishra <mayank31398@gmail.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mayank31398, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the loading mechanism for C++ helper functions to ensure they are consistently available across all distributed processes. It transitions from local imports within functions to a globally managed helper object, improving efficiency and consistency. Additionally, it cleans up an unused import and type hint related to AutoConfig in the training utilities.

Highlights

  • C++ Helper Loading Refactor: The C++ helper functions are now loaded into a global _HELPERS variable, ensuring consistent access across processes and avoiding repeated imports within functions.
  • Distributed Helper Initialization: The compile_helpers function has been updated to ensure that the C++ extensions are compiled and loaded by all distributed processes (rank 0 first, then others after a barrier), making them available globally.
  • Dependency Cleanup: The unused AutoConfig import from transformers and its corresponding type hint in the get_model_tflops function have been removed from train_utils.py, streamlining dependencies.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request addresses an issue with C++ helper imports by refactoring the compilation and usage of these helpers. It introduces a global variable _HELPERS to store the compiled extension, preventing repeated imports. Additionally, it cleans up an unused import and refines a type hint in train_utils.py. The core change correctly moves from local imports to a global reference for the compiled C++ extension, which is a good step towards efficient resource management.

@mayank31398 mayank31398 merged commit 166ee24 into main Jan 30, 2026
2 checks passed
@mayank31398 mayank31398 deleted the n branch January 30, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant